Skip to content

Fix tests on Windows #129195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix tests on Windows #129195

wants to merge 4 commits into from

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Jun 10, 2025 •
edited
Loading

Missed a spot.

Fixes #129167.
Fixes #129168.

@prdoyle prdoyle self-assigned this Jun 10, 2025
@prdoyle prdoyle added the >test Issues or PRs that are addressing/adding tests label Jun 10, 2025
@prdoyle prdoyle requested a review from a team as a code owner June 10, 2025 12:58
@prdoyle prdoyle added test-windows Trigger CI checks on Windows auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels Jun 10, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jun 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

ldematte
ldematte approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think this fixes #129168 too?

@prdoyle
Copy link
Contributor Author

prdoyle commented Jun 10, 2025

I've hit this known failure.

@prdoyle
Copy link
Contributor Author

prdoyle commented Jun 11, 2025

CI failures are probably #114511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldematte ldematte ldematte approved these changes

Assignees

@prdoyle prdoyle

Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests test-windows Trigger CI checks on Windows v8.19.0 v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] FileAccessTreeTests testWindowsAbsolutPathAccess failing [CI] FileAccessTreeTests testWindowsMixedCaseAccess failing
3 participants
@prdoyle @elasticsearchmachine @ldematte